Expose signal value of siginfo_t #1421
Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thank you for the PR. Our CI is currently down because we are migrating to Azure Pipelines, but it looks good, I'll try to merge it this weekend. |
|
Updated with other unix platforms. |
|
@bors: r+ |
|
📌 Commit 2cd9b40 has been approved by |
Expose signal value of siginfo_t Currently exposes it for following platforms: - Linux has it as enum _timer and it is exposed alongside sigval - On FreeBSD like systems si_value follows after si_addr (according to headers) - Darwin is similar to FreeBSD - NetBSD and FreeBSD uses struct that contains pid, uid, and si_value. Exposed via it P.s. I'd like to take a look at other platforms too, but these are what I know so far. FreeBSD needs some testing though cc @gnzlbg
|
💔 Test failed - checks-cirrus-freebsd-11 |
|
You need to double check the size of your pad fields. They aren't right for 64-bit FreeBSD. |
|
Ok, I'll need to check it. |
DoumanAsh
force-pushed
the
expose_posix_timer_value
branch
2 times, most recently
from
cb112c9 to
80f8829
Compare
|
It appears that the freebsd jobs are still failing. |
|
@gnzlbg Yeah, before my traveling I actually was trying to fix MacOS tests, which are still failing for some reason. |
|
you might just need to rebase on top of master, those error shouldn't be there, and don't appear related to this PR |
DoumanAsh
force-pushed
the
expose_posix_timer_value
branch
from
80f8829 to
e92b243
Compare
|
Ok, done, I'll check it out once CI is finished UPD: Removed |
Exposes value for most unix like platforms
DoumanAsh
force-pushed
the
expose_posix_timer_value
branch
from
e92b243 to
0c2e783
Compare
|
@gnzlbg CI passed |
|
@bors: r+ |
|
📌 Commit 0c2e783 has been approved by |
Expose signal value of siginfo_t Currently exposes it for following platforms: - Linux has it as enum _timer and it is exposed alongside sigval - On FreeBSD like systems si_value follows after si_addr (according to headers) - Darwin is similar to FreeBSD - NetBSD and FreeBSD uses struct that contains pid, uid, and si_value. Exposed via it P.s. I'd like to take a look at other platforms too, but these are what I know so far. FreeBSD needs some testing though cc @gnzlbg
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
Currently exposes it for following platforms:
P.s. I'd like to take a look at other platforms too, but these are what I know so far.
FreeBSD needs some testing though
cc @gnzlbg