Skip to content

Redox target fix #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Redox target fix #1422

wants to merge 2 commits into from

Conversation

newpavlov
Copy link
Contributor

Closes #1420

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit 1ca558d has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 6, 2019

⌛ Testing commit 1ca558d with merge 998e8de...

bors added a commit that referenced this pull request Jul 6, 2019
@bors
Copy link
Contributor

bors commented Jul 6, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2019

@newpavlov please implement these like #1403 does.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit 46cee95 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 6, 2019

⌛ Testing commit 46cee95 with merge 3774e10...

bors added a commit that referenced this pull request Jul 6, 2019
@newpavlov
Copy link
Contributor Author

Looks like some more involved fixes are needed. @jackpot51 can you handle cfg fix as part of #1403?

@bors
Copy link
Contributor

bors commented Jul 6, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 6, 2019

@newpavlov I would prefer if that happened in #1403 as well, could you send @jackpot51 a PR with your fix ?

@newpavlov newpavlov mentioned this pull request Jul 6, 2019
@newpavlov
Copy link
Contributor Author

Done! Closing in favor of the linked PR.

@newpavlov newpavlov closed this Jul 6, 2019
@newpavlov newpavlov deleted the redox_fix branch July 6, 2019 17:25
@mati865 mati865 mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building for x86_64-unknown-redox results in an empty crate
5 participants