Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmtime to the latest master. #1437

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

sunfishcode
Copy link
Member

The previous wasmtime revision is broken because one of its dependencies, memoffset 0.3, was yanked, which appears to make it unavailable. This was fixed by downgrading to memoffset 0.2.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 11, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 11, 2019

📌 Commit 0ac8cef has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 11, 2019

⌛ Testing commit 0ac8cef with merge 525291c...

bors added a commit that referenced this pull request Jul 11, 2019
Update wasmtime to the latest master.

The previous wasmtime revision is broken because one of its dependencies, `memoffset` 0.3, was yanked, which appears to make it unavailable. This was fixed by downgrading to `memoffset` 0.2.
@bors
Copy link
Contributor

bors commented Jul 11, 2019

💔 Test failed - checks-cirrus-freebsd-12

@sunfishcode
Copy link
Member Author

I should mention; this PR fixes #1424.

@sunfishcode
Copy link
Member Author

The Travis failure here looks like the same failure happening on master.

@gnzlbg gnzlbg closed this Jul 26, 2019
@gnzlbg gnzlbg reopened this Jul 26, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 26, 2019

Sorry that it took so long, it was unclear what was causing the master failure and it turned out to be the LLVM 9 upgrade... fun times...

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 26, 2019

📌 Commit e21be8c has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 26, 2019

⌛ Testing commit e21be8c with merge c2498d8...

bors added a commit that referenced this pull request Jul 26, 2019
Update wasmtime to the latest master.

The previous wasmtime revision is broken because one of its dependencies, `memoffset` 0.3, was yanked, which appears to make it unavailable. This was fixed by downgrading to `memoffset` 0.2.
@bors
Copy link
Contributor

bors commented Jul 26, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 26, 2019 via email

@bors
Copy link
Contributor

bors commented Jul 26, 2019

⌛ Testing commit e21be8c with merge d660c38...

bors added a commit that referenced this pull request Jul 26, 2019
Update wasmtime to the latest master.

The previous wasmtime revision is broken because one of its dependencies, `memoffset` 0.3, was yanked, which appears to make it unavailable. This was fixed by downgrading to `memoffset` 0.2.
@bors
Copy link
Contributor

bors commented Jul 26, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing d660c38 to master...

@bors bors merged commit e21be8c into rust-lang:master Jul 26, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 27, 2019

@sunfishcode the wasi build job is still failing on master (notice that it is allowed to fail). Would you mind taking a look?

@sunfishcode
Copy link
Member Author

Looks like a compiler problem compiling the new linux_termios test for wasm. I'll investigate further when I get a chance.

@JohnTitor JohnTitor mentioned this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants