Increase Redox & Relibc support #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Jul 12, 2019
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
|
☔ The latest upstream changes (presumably #1432) made this pull request unmergeable. Please resolve the merge conflicts. |
AdminXVII
force-pushed
the
extra-traits-redox
branch
from
d058823 to
0af8f18
Compare
jackpot51
suggested changes
Jul 15, 2019
| if #[cfg(not(target_os = "redox"))] { | ||
| extern { | ||
| pub fn getsid(pid: pid_t) -> pid_t; | ||
| pub fn truncate(path: *const c_char, length: off_t) -> ::c_int; |
There was a problem hiding this comment.
This should definitely be implemented for Redox in relibc, if it is not already
| extern { | ||
| pub fn getsid(pid: pid_t) -> pid_t; | ||
| pub fn truncate(path: *const c_char, length: off_t) -> ::c_int; | ||
| pub fn pause() -> ::c_int; |
There was a problem hiding this comment.
This should definitely be implemented for Redox in relibc, if it is not already
| link_name = "fdopendir$INODE64")] | ||
| #[cfg_attr(all(target_os = "macos", target_arch = "x86"), | ||
| link_name = "fdopendir$INODE64$UNIX2003")] | ||
| pub fn fdopendir(fd: ::c_int) -> *mut ::DIR; |
There was a problem hiding this comment.
This should definitely be implemented for Redox in relibc, if it is not already
|
Note to the reviewer: The changes requested by jackpot51 are to be done after merging this PR. |
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Jul 22, 2019
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
|
@bors: r+ |
|
📌 Commit 4d4a423 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 27, 2019
Increase Redox & Relibc support - Add a lot of constants from relibc - Fix the timezone not found error found previously on Redox - Wrap WIFEXITED _et al._ in an unsafe block to match the rest of the API - Add support for the extra_traits feature and Redox - Fmt cc @jackpot51
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
Closed
Merged
bors
added a commit
that referenced
this pull request
Aug 12, 2019
Bump version to 0.2.61 Releasing a version now will allow Redox compilation to work again, as it will include #1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Sep 11, 2019
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Oct 1, 2019
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Dec 17, 2019
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
Jan 19, 2020
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
May 6, 2020
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
May 14, 2020
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
AdminXVII
added a commit
to AdminXVII/nix
that referenced
this pull request
May 18, 2020
Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
May 20, 2020
1098: Add Redox support for most of the modules r=asomers a=AdminXVII Some things are not implemented yet in redox, so a lot of annotations were added to remove functions when compiling for redox. Those functions will hopefully be added in time, but for now it's better to have partial support than none. Blocked by rust-lang/libc#1438 Co-authored-by: Xavier L'Heureux <xavier.lheureux@icloud.com> Co-authored-by: Xavier L'Heureux <dev.xlheureux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jackpot51