-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add musl support for MIPS64 & bump to 0.2.63 #1449
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
failure is the same as #1450 |
d7b3a2e
to
c6a8efd
Compare
The i686 mingw failure seems unrelated. |
☔ The latest upstream changes (presumably #1376) made this pull request unmergeable. Please resolve the merge conflicts. |
c6a8efd
to
240b370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this all looks good to me.
If there is librustc_target support upstream for these, I would prefer if you would add these targets to ci/build.sh (to the LINUX_NIGHTLY_NOCORE env variable), so that we at least test that these build properly.
Once you get libstd support up and running in rust-lang/rust, then it might be worth it to consider adding the run-time tests for these, but that should happen in a future PR, and not here.
For the record, I for some unknown reason included CI changes in both of the PRs, so neither would build... 🤦♂ |
You can remove the changes to azure.yml here. If you don't want to wait for the target to be available, you can add a |
…ichton Add builtin targets for mips64(el)-unknown-linux-musl This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!*
This needs to be updated (e.g. remove the comments in the azure.yml file, or enable those jobs), also, these targets need to be added to the ci/build.sh file (probably to the NIGHTLY_NOCORE list until we start shipping core and/or libstd for these targets). |
240b370
to
da1aca0
Compare
…ichton Add builtin targets for mips64(el)-unknown-linux-muslabi64 This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!* *edit 2: changed triples to include ABI, and removed stray `crt_static_default = false` declarations to be consistent with other musl targets`
Updated. The |
@bors: r+ |
📌 Commit da1aca0 has been approved by |
Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.
Ah. The Once rust-lang/rust#63165 lands this can be retried; merging of this should be avoided before that. |
💥 Test timed out |
…ichton Add builtin targets for mips64(el)-unknown-linux-muslabi64 This is prerequisite for rust-lang/libc#1449. Tested locally to produce working static and dynamic binaries, ~~but CI config is untested for now~~ CI is to be added in a follow-up PR. *edit: dynamic binaries also confirmed working!* *edit 2: changed triples to include ABI, and removed stray `crt_static_default = false` declarations to be consistent with other musl targets*
@xen0n while the PR to rust-lang/rust landed, new nightly toolchains are only created approx. once per day, so usually you have to wait until tomorrow. Don't despair ;) |
@bors: r+ |
📌 Commit 42139b8 has been approved by |
Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.
💔 Test failed - status-azure |
42139b8
to
435cdee
Compare
Turns out I misunderstood the new CI pipeline... libc/ci/azure-install-rust.yml Lines 24 to 30 in 4bd0c00
It seems any target in the build matrix needs to have |
Yes, you only can do that once you have enabled |
@bors: r+ |
📌 Commit 435cdee has been approved by |
Add musl support for MIPS64 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.
We're blocked by #1473. Should we just cherry-pick the build-fixing commit to at least unblock things? |
💔 Test failed - status-azure |
@bors: retry |
Add musl support for MIPS64 & bump to 0.2.63 Tested with patched stage2; both static and dynamic binaries confirmed working. Initial CI support in the form of no-core targets are added.
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
Could this version bump be pushed to crates.io, so I can continue work on upstreaming the corresponding |
Sure |
Released, sorry for the delay, we had too many time outs the last couple of days. |
Tested with patched stage2; both static and dynamic binaries confirmed working.
Initial CI support in the form of no-core targets are added.