WIP: Support all possible netlink constants in gnu/mod.rs on musl #1452
+62
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
…will probably fail CI
jbaublitz
force-pushed
the
musl-netlink-support
branch
from
d51d3b7 to
e4dcbbe
Compare
|
I'm going to close this out and make a new PR. I set up my own musl-based CI that seems to work with this and the new pipelines that you mentioned in #1460 don't seem to be showing up. |
bors
added a commit
that referenced
this pull request
Aug 10, 2019
Move musl-compatible constants to linux/mod.rs This is a continuation of #1452. I think CI is ready to run fully and the PR is ready to be merged if the pipelines pass based on the CI I've done using musl libc in my own projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to discover which netlink constants need to be gated in
gnu/mod.rsand which ones are okay inmod.rsfor Linux. It seems many of the early constants added were defaulted to GNU only which is not necessarily needed. This will probably fail CI a few times before I am able to remove WIP.