Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: Implement Eq, Hash, PartialEq for sockaddr_* types #159

Closed
wants to merge 2 commits into from

Conversation

kamalmarhubi
Copy link
Contributor

No description provided.

@kamalmarhubi
Copy link
Contributor Author

Confused by the nightly x86_64 only failure: https://travis-ci.org/rust-lang-nursery/libc/jobs/105324244#L233

@alexcrichton
Copy link
Member

Thanks for the PR! Currently, however, the libc crate is intended to be as thin a wrapper as possible around the system libc, for example it only provides the guarantee that structs are Copy (which also forces a Clone impl).

At this time we're not looking for higher level abstractions in libc (e.g. any other form of "Rust code" like Eq or Hash). That's in general left to higher level libraries.

@kamalmarhubi
Copy link
Contributor Author

Thanks for the explanation!

@kamalmarhubi kamalmarhubi deleted the sockaddr-hash branch January 31, 2016 07:06
kamalmarhubi referenced this pull request in abbradar/nix-rust Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants