Skip to content

Disable broken targets #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Disable broken targets #1593

merged 1 commit into from
Nov 18, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Nov 13, 2019

No description provided.

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 13, 2019

@bors: r+

1 similar comment
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 13, 2019

@bors: r+

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 13, 2019

r? me

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 13, 2019

@bors: +r

@mati865
Copy link
Member

mati865 commented Nov 13, 2019

@bors are you still there?

@mati865
Copy link
Member

mati865 commented Nov 13, 2019

It's broken, you should call infra.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 14, 2019

@pietroalbini I see that GA is already active. Maybe that messed up bors somehow ? AFAICT rust-central-station is still using Azure, which is still correct.

@mati865
Copy link
Member

mati865 commented Nov 14, 2019

Can you retry any i686 windows-gnu build before disabling it?
I'm curious if LLVM backport has fixed it.

@mati865
Copy link
Member

mati865 commented Nov 14, 2019

Still broken, thanks for testing.
I'll update #1592 (comment)

@pietroalbini
Copy link
Member

I'll take a look tomorrow.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 17, 2019

@bors: +r r+

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@bors: r+

@pietroalbini
Copy link
Member

pietroalbini commented Nov 18, 2019

Let me investigate.

@gnzlbg can you delegate me for this PR? It should be @bors delegate=pietroalbini.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@bors delegate=pietroalbini

@pietroalbini
Copy link
Member

@bors r=gnzlbg

@bors
Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit 0910f3b has been approved by gnzlbg

@pietroalbini
Copy link
Member

@gnzlbg hmm, now it seems to be unstuck, but synchronization added failed PRs to the queue. Can you @bors r- retry the failed ones in https://buildbot2.rust-lang.org/homu/queue/libc ?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit 0910f3b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 18, 2019

⌛ Testing commit 0910f3b with merge fcf27fb...

bors added a commit that referenced this pull request Nov 18, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@pietroalbini looks like its working now

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

What did you do to "unstuck" bors ?

@pietroalbini
Copy link
Member

pietroalbini commented Nov 18, 2019

@gnzlbg I hit the "synchronize" button in the queue page. That button flushes all the cache bors has about a repo, forcing it to scrape all the open PRs again. It usually solves most of the problems, but it's a bit buggy (as you saw with the failed PRs being queued again). It should be used as a last resort, and it's usually best to ping us before hitting it.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

Thanks for fixing this!

@bors
Copy link
Contributor

bors commented Nov 18, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@bors: +r

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 18, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 18, 2019

⌛ Testing commit 0910f3b with merge b96c0dd...

bors added a commit that referenced this pull request Nov 18, 2019
@bors
Copy link
Contributor

bors commented Nov 18, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing b96c0dd to master...

@bors bors merged commit 0910f3b into rust-lang:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants