-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement utmp for solarish targets #1603
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
@GrayJack Can you fix the spelling error "solarish" => "solaris"? |
@glaubitz I did used that intentionally, since internally the module is called I think there was a discussion to have a illumos target for Rust, probably cause there is enough differences between both nowadays. But if that is really gonna be a problem, sure, I can change |
Another community member coined the term -- while there's a common heritage between illumos and Solaris, they've been separate projects for well over a decade now and have diverged in some areas so it's similar to the BSDs in that sense (a lot of things in common, and a number of things that are different). As to the change itself, it looks good to me. |
Looks good to me, too. |
@bors: r+
|
📌 Commit 54283f9 has been approved by |
Implement utmp for solarish targets I followed these references: https://github.com/illumos/illumos-gate/blob/4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4/usr/src/head/utmpx.h https://github.com/illumos/illumos-gate/blob/4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4/usr/src/head/utmp.h
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
I followed these references:
https://github.com/illumos/illumos-gate/blob/4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4/usr/src/head/utmpx.h
https://github.com/illumos/illumos-gate/blob/4e0c5eff9af325c80994e9527b7cb8b3a1ffd1d4/usr/src/head/utmp.h