Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement utmp for solarish targets #1603

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@glaubitz
Copy link
Contributor

@GrayJack Can you fix the spelling error "solarish" => "solaris"?

@GrayJack
Copy link
Contributor Author

@glaubitz I did used that intentionally, since internally the module is called solarish, probably because there more than one platform that have the same base (Oracle Solaris and Illumos).

I think there was a discussion to have a illumos target for Rust, probably cause there is enough differences between both nowadays.

But if that is really gonna be a problem, sure, I can change

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019

cc @jasonbking @bgermann

@jasonbking
Copy link
Contributor

Another community member coined the term -- while there's a common heritage between illumos and Solaris, they've been separate projects for well over a decade now and have diverged in some areas so it's similar to the BSDs in that sense (a lot of things in common, and a number of things that are different). As to the change itself, it looks good to me.

@bgermann
Copy link
Contributor

Looks good to me, too.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 25, 2019 via email

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 54283f9 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 54283f9 with merge 581ba35...

@bors
Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 581ba35 to master...

@bors bors merged commit 54283f9 into rust-lang:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants