Dragonfly: expose __errno_location() rather than define __error(). #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose __errno_location() (introduced in DragonFlyBSD 5.8), which returns the current thread's errno value. This is similar to Linux and avoids having a separate module that defines both errno (which depends on the thread_local feature) and an __error() function.
|
I think this will break the backward compatibility, right? Then I'd like to avoid just removing it but add a deprecation note for a while then drop it. |
|
Good point. I suspect not many people use it, but no easy way to tell. I added the errno module back, along with its reference. The function has a deprecation warning now. |
|
Do these changes look acceptable? |
JohnTitor
approved these changes
Sep 2, 2020
|
awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of a recent addition to DragonFly that makes it possible to access errno (which is thread-local) without any dependence on the thread_local Rust feature. I tested it out by using it in the Nix crate. Nix had a C language shim, which I removed and replaced by using this modified version of libc.