Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UIO_MAXIOV constant to uclibc #1895

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

schultetwin1
Copy link

#1880 added UIO_MAXIOV to linux-like libc, but did not add it
to uclibc. This causes build breaks for std against uclibc.

!1880 added UIO_MAXIOV to libc, but did not add it to uclibc. This
causes build breaks for std against uclibc.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Looks good, but CI didn't agree with it. Let's re-run it to see if it still happens.

@JohnTitor JohnTitor closed this Sep 19, 2020
@JohnTitor JohnTitor reopened this Sep 19, 2020
@JohnTitor
Copy link
Member

Found out that rust-lang/rust#74532 causes the failure on macOS nightly CI (s390x's is spurious and semver check's is unrelated to this). I'd skip the build check for that target if the upstream doesn't get a fix in a few days.

@schultetwin1
Copy link
Author

Sounds good! Thanks for looking into that.

@JohnTitor JohnTitor closed this Sep 30, 2020
@JohnTitor JohnTitor reopened this Sep 30, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's now green. Thanks!

@JohnTitor JohnTitor merged commit 0293c44 into rust-lang:master Sep 30, 2020
@schultetwin1
Copy link
Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants