Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENOTSUP constant for uclibc #1971

Closed
wants to merge 1 commit into from
Closed

Conversation

skrap
Copy link
Contributor

@skrap skrap commented Nov 5, 2020

In the vein of other linux-like c libs, just define ENOTSUP as equal to EOPNOTSUPP.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@skrap
Copy link
Contributor Author

skrap commented Nov 6, 2020

Actually I'm not sure that this is correct. Seems like ENOTSUP is defined in libc/src/unix/uclibc/mips/mod.rs already. I must not understand when something belongs in an arch-specific sub-module.

Some of this must have been generated programmatically. If anyone knows how that was done, I'd love a heads up.

@skrap skrap closed this Nov 6, 2020
bors added a commit that referenced this pull request May 8, 2022
Add ENOTSUP constant for riscv64 musl

Previously:

* #2595
* #1971
* #448

but not of these added the constant for riscv64 musl and rustc itself seems to use it nowadays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants