unix: Include fdatasync(2) on non-Apple systems #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this may not exist on FreeBSD? |
The function is defined in POSIX [0], but according to Gnulib docs [1], it is missing or not declared on at least some versions of OS X and FreeBSD. On Solaris, it is not a system call but is present as fdatasync(3) [2]. [0] http://www.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html [1] https://www.gnu.org/software/gnulib/manual/html_node/fdatasync.html [2] http://docs.oracle.com/cd/E36784_01/html/E36874/fdatasync-3c.html
|
Urgh sorry, I was sure I'd checked. I need to figure out how to run these tests locally! |
|
I think the windows failure is spurious. The failing job has no log: https://ci.appveyor.com/project/alexcrichton/libc/build/1.0.762/job/q46jx47ua7exb5ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is defined in POSIX [0], but according to Gnulib docs [1],
it is missing or not declared on at least some versions of OS X. On
Solaris, it is not a system call but is present as fdatasync(3) [2].
[0] http://www.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html
[1] https://www.gnu.org/software/gnulib/manual/html_node/fdatasync.html
[2] http://docs.oracle.com/cd/E36784_01/html/E36874/fdatasync-3c.html