-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fspacectl, new in FreeBSD 14 #2543
Conversation
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
Finally we should prepare FreeBSD 14 CI, let me do that before merging. |
☔ The latest upstream changes (presumably #2545) made this pull request unmergeable. Please resolve the merge conflicts. |
Needs a rebase. |
Rebased, @JohnTitor . |
ef7e4be
to
b777759
Compare
self.r_offset == other.r_offset | ||
&& self.r_len == other.r_len | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just #[derive]
these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, off_t
can be derived thus that can be moved inside of s!
, I think.
I rebased the changes, derived the extra traits, and made spacectl_range's fields public. |
@bors r+ |
📌 Commit be39286 has been approved by |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
rust-lang/libc#2543 was merged and is available starting from 0.2.114. Using published version of libc makes it easier to use git version of nix
1658: use version of libc published on crates r=rtzoeller a=pacak rust-lang/libc#2543 was merged and is available starting from 0.2.114. Using published version of libc makes it easier to use git version of nix Co-authored-by: Michael Baikov <manpacket@gmail.com>
No description provided.