Don't check typedefs in impls in style checker #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
JohnTitor
force-pushed
the
style-check-fix
branch
from
de43938 to
ba9676c
Compare
JohnTitor
changed the title
JohnTitor
commented
Jun 12, 2022
Comment on lines
-111
to
-127
| if line == "" { | ||
| if prev_blank { | ||
| err.error(path, i, "double blank line"); | ||
| } | ||
| prev_blank = true; | ||
| } else { | ||
| prev_blank = false; | ||
| } | ||
| if line != line.trim_end() { | ||
| err.error(path, i, "trailing whitespace"); | ||
| } | ||
| if line.contains("\t") { | ||
| err.error(path, i, "tab character"); | ||
| } | ||
| if line.len() > 100 && !(line.contains("https://") || line.contains("http://")) { | ||
| err.error(path, i, "line longer than 100 chars"); | ||
| } |
There was a problem hiding this comment.
Removed some checks as rustfmt would validate them.
|
Thanks! |
|
@bors r+ |
|
📌 Commit ba9676c has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Okushi jtitor@2k36.org