Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type of file flags on OpenBSD #2841

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Jul 10, 2022

In C they're defined as macros, but since they're used with chflags(2)
they should have the same type as that function's flags argument.

In C they're defined as macros, but since they're used with chflags(2)
they should have the same type as that function's flags argument.
@rust-highfive
Copy link

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the chflags(2) prototype is int chflags(const char *path, unsigned int flags);, so yes, it makes sense.

LGTM

@Amanieu
Copy link
Member

Amanieu commented Jul 12, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 12, 2022

📌 Commit 27264ed has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 12, 2022

⌛ Testing commit 27264ed with merge 8dbd2c9...

@bors
Copy link
Contributor

bors commented Jul 12, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: Amanieu
Pushing 8dbd2c9 to master...

@bors bors merged commit 8dbd2c9 into rust-lang:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants