-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solarish amd64 regset constants #2930
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
c02342b
to
9178f55
Compare
I think it looks OK, but I have one question (directed to @devnexen): Are there existing or potential consumers which are driving these additions? There have been bits added in the past -- MR_HDR_AOUT is the most recent example -- an effectively Uncommitted interfaces which, when cleaned up caused the libc-test suite to start failing on new machines. I'm happy to see additions if they will (or are likely to) be used, and are not exposing bits of the OS which are less than Committed. Thanks |
This particular set is indeed used within a getcontext part, it would be more readable using these constants. |
I'm going to r+ considering this is approved with the above. @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
No description provided.