Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xous: add initial C definitions #3084

Merged
merged 1 commit into from
Feb 5, 2023
Merged

xous: add initial C definitions #3084

merged 1 commit into from
Feb 5, 2023

Conversation

xobs
Copy link
Contributor

@xobs xobs commented Jan 22, 2023

This adds initial C definitions to Xous. There is no C library, so this mostly serves to add C-compatible exports to the libc crate.

@xobs
xous: add initial C definitions
be1d79d 
This adds initial C definitions to Xous. There is no C library, so this
mostly serves to add C-compatible exports to the `libc` crate.

Signed-off-by: Sean Cross <sean@xobs.io>
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@xobs
Copy link
Contributor Author

xobs commented Jan 22, 2023

Note that I have NOT added a file to libc/semver/ because Xous has no C functions, and so this file would be empty.

@JohnTitor
Copy link
Member

We're pausing accepting external targets currently, see #3032 for details.

@xobs
Copy link
Contributor Author

xobs commented Jan 28, 2023

What is classified as an external target? Is it only tier 2 and lower?

JohnTitor
JohnTitor reviewed Feb 5, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

Ah I thought there was no official target for xous but it's not true (that's what we discussed in the above linked PR, read it for the context). r=me once the above is resolved.

@xobs xobs force-pushed the initial-xous-support branch from 67d8295 to be1d79d Compare February 5, 2023 02:09
@xobs
Copy link
Contributor Author

xobs commented Feb 5, 2023

Alright, I removed that commit. Note that the freebsd build is broken due to what apparently is a missing symbol in curl, preventing it from downloading things.

r=johntitor

@JohnTitor
Copy link
Member

Thanks!

Note that the freebsd build is broken due to what apparently is a missing symbol in curl, preventing it from downloading things.

It has been fixed on master, it happens because the branch here is a bit old, so no problem at all :)

@JohnTitor
Copy link
Member

Oh I forgot: @bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2023

📌 Commit be1d79d has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 5, 2023

⌛ Testing commit be1d79d with merge 7349741...

@bors
Copy link
Contributor

bors commented Feb 5, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 7349741 to master...

@bors bors merged commit 7349741 into rust-lang:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xobs @rustbot @JohnTitor @bors