Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing freebsd 11 EOL proposal. #3139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Mar 5, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@devnexen devnexen marked this pull request as ready for review March 5, 2023 10:34
@JohnTitor
Copy link
Member

Note that there're some overrides with #2406.

@bors
Copy link
Contributor

bors commented Mar 8, 2023

☔ The latest upstream changes (presumably #3037) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented May 6, 2023

☔ The latest upstream changes (presumably #2999) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee
Copy link
Member

@devnexen Please resolve the merge conflict.

build.rs Outdated
Some(13) if libc_ci => set_cfg("freebsd13"),
Some(14) if libc_ci => set_cfg("freebsd14"),
Some(_) | None => set_cfg("freebsd11"),
Some(12) if libc_ci => println!("cargo:rustc-cfg=freebsd12"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a merge conflict. You should use set_cfg instead of println!

// APIs that were changed after FreeBSD 11

// The type of `nlink_t` changed from `u16` to `u64` in FreeBSD 12:
pub type nlink_t = u16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the stuff that was in this file should now be moved into freebsdlike/freebsd/mod.rs For example, move all three nlink_t definitions from freebsd{12,13,14}.rs into that file.

@devnexen devnexen force-pushed the remove_fbsd11_support branch 2 times, most recently from 80e37e1 to ce5b55f Compare July 26, 2023 22:36
@workingjubilee
Copy link
Member

workingjubilee commented Jul 28, 2023

I started a conversation on Zulip to see how people feel about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants