Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing kqueue constants across BSDs #3150

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Add missing kqueue constants across BSDs #3150

merged 1 commit into from
Apr 2, 2023

Conversation

valpackett
Copy link
Contributor

While here, reorder some to match the C headers

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2023

Some changes occurred in OpenBSD module

cc @semarie

semarie
semarie approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding OpenBSD, it LGTM

@valpackett
Add missing kqueue constants across BSDs
b3853e8 
While here, reorder some to match the C headers
@valpackett
Copy link
Contributor Author

ping

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2023

📌 Commit b3853e8 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 1, 2023

⌛ Testing commit b3853e8 with merge a0a68c2...

bors added a commit that referenced this pull request Apr 1, 2023
@bors
Auto merge of #3150 - valpackett:kq, r=JohnTitor
a0a68c2 
Add missing kqueue constants across BSDs

While here, reorder some to match the C headers
@bors
Copy link
Contributor

bors commented Apr 1, 2023

💔 Test failed - checks-cirrus-freebsd-14

@valpackett
Copy link
Contributor Author

That's some new checks introduced in nightly rust 👀

thread 't::test_cmsg_nxthdr' panicked at 'misaligned pointer dereference: address must be a multiple of 0x4 but is 0x1b6966ed4d1', libc-test/test/cmsg.rs:74:25

google showing one result

Looks like this: rust-lang/rust#98112

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Apr 2, 2023

⌛ Testing commit b3853e8 with merge 5c57d3e...

@bors
Copy link
Contributor

bors commented Apr 2, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 5c57d3e to master...

@bors bors merged commit 5c57d3e into rust-lang:master Apr 2, 2023
@valpackett valpackett deleted the kq branch April 2, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@semarie semarie semarie approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valpackett @rustbot @JohnTitor @bors @semarie