Fix ABI compatibility with Emscripten >= 3.1.42 #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Jun 25, 2023
|
Thanks! @bors r+ |
bors
added a commit
that referenced
this pull request
Jun 25, 2023
Fix ABI compatibility with Emscripten >= 3.1.42 See: emscripten-core/emscripten#19569 (comment)
|
💔 Test failed - checks-actions |
|
Seems we have to early return if rustc version is too old (I think it's fine as the usage rate should be quite low). |
|
I think commit 92db93c would fix the build on older Rust versions. |
|
Seems good 👍, @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
emscripten-core/emscripten#19569 (comment)