-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: add a few kTLS defintions #3287
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks @gennyble for opening this! I need this PR + a point release to (ultimately) land nix-rust/nix#2065 which in turn unblocks doing in-kernel TLS properly from rust with tokio, cf. rustls/ktls#26 (I know, exciting!) |
I see a skip might be an option? |
@JohnTitor would it be possible to get a look at this? Maybe from another maintainer, if you're not able to? |
Correct. |
Instead of skipping I added the header to the linux kernel headers for libc-test. @rustbot review |
Cool, thanks! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Thanks for getting this merged! When can we expect this to be included in a crates.io release of libc ? (So we can bump the version nix relies on) |
@JohnTitor the latest libc release was cut on June 25, 2023 - I think this means this PR still isn't on crates.io? The problem is we're trying to use those new additions from https://lib.rs/crates/nix, so a git dependency isn't really an option here. Edit: opened #3350 to track this Edit 2: @joshtriplett released 0.2.148 just now. |
related: nix-rust/nix#2065
i think android has support, too, but if I put it in
linux-like
does that imply emscripten support?