Use build-std=core instead of build-std alone

[GuillaumeGomez]

Should help with #3289.

[rustbot]

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

[jyn514]

have you tested locally that cargo doc-Zbuild-std=core works? please don't test by publishing, i only have limited time to help.

[GuillaumeGomez]

Yes, tested with two targets:

$ cargo doc -Zbuild-std=core --target=arm-linux-androideabi
    Updating crates.io index
   Compiling compiler_builtins v0.1.92
   Compiling core v0.0.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
   Compiling libc v0.2.147 (/home/imperio/rust/libc)
   Compiling rustc-std-workspace-core v1.99.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
 Documenting libc v0.2.147 (/home/imperio/rust/libc)
    Finished dev [unoptimized + debuginfo] target(s) in 9.69s

$ cargo doc -Zbuild-std=core --target=aarch64-linux-android
   Compiling compiler_builtins v0.1.92
   Compiling core v0.0.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
   Compiling libc v0.2.147 (/home/imperio/rust/libc)
   Compiling rustc-std-workspace-core v1.99.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
 Documenting libc v0.2.147 (/home/imperio/rust/libc)
    Finished dev [unoptimized + debuginfo] target(s) in 8.47s

Do you want me to test something else just in case?

[jyn514]

that seems fine - but just fyi most of the failures i mentioned #3289 (comment) are probably going to continue to be issues

[GuillaumeGomez]

It's fine for now. I can take a look at them later on, it's less pressing than the current state. ^^'

[JohnTitor]

Thanks! @bors r+

[bors]

📌 Commit bcecfe5 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit bcecfe5 with merge 1a612bb...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 1a612bb to main...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 1a612bb to main...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

[GuillaumeGomez]

eyes Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Anything I need to do about this?

[JohnTitor]

The commit was pushed anyway so we don't have to do anything (I believe this is a bug/weird behavior of bors, I remember seeing this message on the rust repo).

EDIT: Well, it seems the message is a bit different from what I've ever seen. Anyway, the main branch should have this change and we can call it a day unless any additional commits are missing.

[GuillaumeGomez]

Noted, thanks for checking! Don't hesitate if I need to fix something.