Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing targets for documentation and remove duplicates for list #3309

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

GuillaumeGomez
Copy link
Member

I just noticed that the apple targets were not documented on docs.rs so I added them.

I also saw some duplicates in the list. Do you want me to add a check to ensure that there are no duplicates?

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Do you want me to add a check to ensure that there are no duplicates?

I think the priority is low as the list wouldn't be updated so frequently. Let's add that if the same error happens in the future!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 28, 2023

📌 Commit a38f140 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 28, 2023

⌛ Testing commit a38f140 with merge 28ab9b9...

@GuillaumeGomez
Copy link
Member Author

I think the priority is low as the list wouldn't be updated so frequently. Let's add that if the same error happens in the future!

Noted! Don't hesitate to tell me if it needs to be added, I'll gladly do it.

@bors
Copy link
Contributor

bors commented Jul 28, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 28ab9b9 to main...

@bors bors merged commit 28ab9b9 into rust-lang:main Jul 28, 2023
10 checks passed
@GuillaumeGomez GuillaumeGomez deleted the missing-doc-targets branch July 28, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants