-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include flock support on Solaris #3310
Closed
inferiorhumanorgans
wants to merge
2
commits into
rust-lang:main
from
inferiorhumanorgans:solaris-no-flock
Closed
Don't include flock support on Solaris #3310
inferiorhumanorgans
wants to merge
2
commits into
rust-lang:main
from
inferiorhumanorgans:solaris-no-flock
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
9 tasks
Disable the flock wrapper and related consts on Solaris, but leave them in place for OpenSolaris derivatives like Illumos which do have a BSD-esque flock.
inferiorhumanorgans
force-pushed
the
solaris-no-flock
branch
from
July 30, 2023 00:58
244e960
to
cca407c
Compare
jclulow
suggested changes
Jul 30, 2023
JohnTitor
approved these changes
Aug 20, 2023
@bors r+ |
bors
added a commit
that referenced
this pull request
Aug 20, 2023
Don't include flock support on Solaris This should disable the flock wrapper and related consts on Solaris, but leave them in place for OpenSolaris derivatives like Illumos which do have a BSD-esque flock.
💔 Test failed - checks-cirrus-freebsd-13 |
So is the answer to pull this out of a |
Triage: Closing as inactive, feel free to re-submit a new PR if you're still interested in this change. Thank you anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should disable the flock wrapper and related consts on Solaris, but leave them in place for OpenSolaris derivatives like Illumos which do have a BSD-esque flock.