-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasi select, FD_SET, FD_ZERO, FD_ISSET #3681
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Could you start a wasi file at libc-test/semver and add these? Also needs a rebase. I believe this is the original source: https://github.com/WebAssembly/wasi-libc/blob/230d4be6c54bec93181050f9e25c87150506bdd0/libc-bottom-half/headers/public/__fd_set.h and https://github.com/WebAssembly/wasi-libc/blob/230d4be6c54bec93181050f9e25c87150506bdd0/libc-bottom-half/headers/public/__typedef_fd_set.h#L10-L12 |
@rustbot author |
770f653
to
194fe1b
Compare
194fe1b
to
e9da8a0
Compare
@rustbot review |
Thanks! This is fine as-is, but please consider adding |
(backport <rust-lang#3681>) (cherry picked from commit 1edaad1)
(backport <rust-lang#3681>) (cherry picked from commit e9da8a0)
@youknowone it looks like this isn't working when the Line 4 in 5375260
Try the build locally, you may also need |
Please check if it fits in the project policy.
This is port of wasi-libc type definitions and functions. wasi-libc has different
fd_set
design to widely used one.