Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix: add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback #3693

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

safinaskar
Copy link

@safinaskar safinaskar commented May 10, 2024

This is not breaking change.

Note that this PR adds global variables (statics) in6addr_any and in6addr_loopback. But this is okay, because:

This PR closes #1950

Also I suggest merging this PR for ctest2: JohnTitor/ctest2#56 , it removes annoying warnings produced by ctest2 in presence of statics. And also fixes CI for ctest2. I recommend merging JohnTitor/ctest2#56 , but this is not required

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@safinaskar safinaskar marked this pull request as draft May 10, 2024 22:53
@safinaskar safinaskar force-pushed the in6addr branch 6 times, most recently from a797ab0 to a28a046 Compare May 11, 2024 00:27
@safinaskar safinaskar changed the title [libc 1.0] in6addr_loopback [libc 1.0] Add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback May 11, 2024
@safinaskar safinaskar marked this pull request as ready for review May 11, 2024 01:29
@tgross35 tgross35 changed the title [libc 1.0] Add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback Add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback Aug 16, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are defined here https://github.com/bminor/glibc/blob/b22923abb046311ac9097a36b97b9b97342bac44/inet/netinet/in.h#L237-L240. We do also have a few statics around, e.g.

libc/src/solid/mod.rs

Lines 838 to 842 in 50b4720

pub static mut optarg: *mut c_char;
pub static mut opterr: c_int;
pub static mut optind: c_int;
pub static mut optopt: c_int;
pub static mut optreset: c_int;
.

LGTM, thanks!

@tgross35 tgross35 added this pull request to the merge queue Aug 16, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 16, 2024
@tgross35 tgross35 changed the title Add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback Unix: add IN6ADDR_ANY_INIT, IN6ADDR_LOOPBACK_INIT, in6addr_any, in6addr_loopback Aug 16, 2024
Merged via the queue into rust-lang:main with commit 247591b Aug 16, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
…pback

(backport <rust-lang#3693>)
[ add __align where needed to support old rustc - Trevor ]
(cherry picked from commit 8db9bc7)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
…pback

(backport <rust-lang#3693>)
[ move constants to the align module to support old rustc - Trevor ]
(cherry picked from commit 8db9bc7)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
…pback

(backport <rust-lang#3693>)
[ move constants to the align module to support old rustc - Trevor ]
(cherry picked from commit 8db9bc7)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No IN6ADDR_ANY_INIT or in6_addr_any IPV6 initializers
4 participants