-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix: add IN6ADDR_ANY_INIT
, IN6ADDR_LOOPBACK_INIT
, in6addr_any
, in6addr_loopback
#3693
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
a797ab0
to
a28a046
Compare
IN6ADDR_ANY_INIT
, IN6ADDR_LOOPBACK_INIT
, in6addr_any
, in6addr_loopback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are defined here https://github.com/bminor/glibc/blob/b22923abb046311ac9097a36b97b9b97342bac44/inet/netinet/in.h#L237-L240. We do also have a few statics around, e.g.
Lines 838 to 842 in 50b4720
pub static mut optarg: *mut c_char; | |
pub static mut opterr: c_int; | |
pub static mut optind: c_int; | |
pub static mut optopt: c_int; | |
pub static mut optreset: c_int; |
LGTM, thanks!
IN6ADDR_ANY_INIT
, IN6ADDR_LOOPBACK_INIT
, in6addr_any
, in6addr_loopback
IN6ADDR_ANY_INIT
, IN6ADDR_LOOPBACK_INIT
, in6addr_any
, in6addr_loopback
…pback (backport <rust-lang#3693>) (cherry picked from commit 8db9bc7)
…pback (backport <rust-lang#3693>) [ add __align where needed to support old rustc - Trevor ] (cherry picked from commit 8db9bc7)
…pback (backport <rust-lang#3693>) [ move constants to the align module to support old rustc - Trevor ] (cherry picked from commit 8db9bc7)
…pback (backport <rust-lang#3693>) [ move constants to the align module to support old rustc - Trevor ] (cherry picked from commit 8db9bc7)
This is not breaking change.
Note that this PR adds global variables (statics)
in6addr_any
andin6addr_loopback
. But this is okay, because:ctest2
knows how to test global variables: https://docs.rs/ctest2/0.4.8/ctest2/struct.TestGenerator.html#method.skip_staticThis PR closes #1950
Also I suggest merging this PR for ctest2: JohnTitor/ctest2#56 , it removes annoying warnings produced by ctest2 in presence of statics. And also fixes CI for ctest2. I recommend merging JohnTitor/ctest2#56 , but this is not required