adding new illumos ptsname_r call. #3867
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rustbot label stable-nominated |
rustbot
added
the
stable-nominated
devnexen
force-pushed
the
illumos_ptsname_r
branch
from
c9d3388
to
f069c8d
Compare
pfmooney
reviewed
Aug 25, 2024
src/unix/solarish/illumos.rs
Outdated
| @@ -68,6 +68,8 @@ pub const B4000000: ::speed_t = 31; | |||
| // sys/systeminfo.h | |||
| pub const SI_ADDRESS_WIDTH: ::c_int = 520; | |||
|
|
|||
| pub const PTHREAD_MUTEX_DEFAULT: ::c_int = 8; | |||
There was a problem hiding this comment.
This define cannot be changed in libc so soon. It was only changed in illumos in February 2024. Any running systems which predate the change (which there are many) would potentially malfunction if newly-compiled rust binaries use this newer value.
There was a problem hiding this comment.
so we are ok if unit tests do not necessarily pass then ?
devnexen
force-pushed
the
illumos_ptsname_r
branch
from
f069c8d
to
2c6ad42
Compare
|
description updated |
tgross35
approved these changes
Sep 2, 2024
|
@pfmooney any chance you could double check this with the changes? |
|
This looks straightforward enough to me so I'll just merge it. I won't backport it for a few days at least, @pfmooney feel free to leave an ack/nack at any time. |
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Oct 16, 2024
(backport <rust-lang#3867>) (cherry picked from commit 2c6ad42)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while at it, fixing PTHREAD_MUTEX_DEFAULT which differs from solaris.
man page