Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getpwnam_r and getpwuid_r to emscripten #3906

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add getpwnam_r and getpwuid_r to emscripten #3906

merged 1 commit into from
Sep 24, 2024

Conversation

ChanTsune
Copy link
Contributor

getpwnam and getpwuid exist, but *_r functions do not exist for Emscripten, so I added them.

Header sources:
getpwnam_r
getpwuid_r

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

tgross35
tgross35 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Sep 24, 2024
@tgross35 tgross35 added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-ci and removed S-waiting-on-review labels Sep 24, 2024
Merged via the queue into rust-lang:main with commit d5b17d5 Sep 24, 2024
41 checks passed
@ChanTsune ChanTsune deleted the emscripten-pwd branch September 25, 2024 00:38
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@ChanTsune @tgross35
Add getpwnam_r, getpwuid_r to emscripten (rust-lang#3906)
6372976 
(backport <rust-lang#3906>)
(cherry picked from commit d5b17d5)
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@ChanTsune @tgross35
Add getpwnam_r, getpwuid_r to emscripten (rust-lang#3906)
a37cdde 
(backport <rust-lang#3906>)
(cherry picked from commit d5b17d5)
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-ci stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChanTsune @rustbot @tgross35 @JohnTitor