Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for NuttX #3909

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Initial support for NuttX #3909

merged 1 commit into from
Sep 25, 2024

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Sep 10, 2024

Define the essential types that for NuttX OS.

NuttX has beed added to Rust by rust-lang/rust#127755, this patch is try to introduce basic libc support for NuttX, see the discussion in NuttX community:
apache/nuttx#12960
apache/nuttx#13245

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@bors
Copy link
Contributor

bors commented Sep 17, 2024

☔ The latest upstream changes (presumably #3866) made this pull request unmergeable. Please resolve the merge conflicts.

@no1wudi no1wudi marked this pull request as draft September 19, 2024 08:49
@no1wudi no1wudi marked this pull request as ready for review September 20, 2024 03:46
Define the essential types that for NuttX OS.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@tgross35
Copy link
Contributor

I didn't read through everything thoroughly but since this is a tier3 target and you are the maintainer, I'll take your word for it :). Based on your links it seems like the exact API may need some development, but you can update as needed.

@rustbot label +stable-nominated

@tgross35 tgross35 added this pull request to the merge queue Sep 25, 2024
@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 25, 2024
Merged via the queue into rust-lang:main with commit c31dfc1 Sep 25, 2024
41 checks passed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 25, 2024
Initial std library support for NuttX

This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2024
Rollup merge of rust-lang#130595 - no1wudi:master, r=ibraheemdev

Initial std library support for NuttX

This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.
no1wudi added a commit to no1wudi/libc that referenced this pull request Oct 10, 2024
Define the essential types that for NuttX OS.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@no1wudi no1wudi mentioned this pull request Oct 10, 2024
3 tasks
no1wudi added a commit to no1wudi/libc that referenced this pull request Oct 10, 2024
Define the essential types that for NuttX OS.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
Define the essential types that for NuttX OS.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#3909>)
(cherry picked from commit c31dfc1)
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
Define the essential types that for NuttX OS.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#3909>)
(cherry picked from commit c31dfc1)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants