-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rtems cfg-ed import with the others #3932
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
@thesummer just noticed this when starting a backport, is there any reason it was in a separate cfg block in #3866? |
@tgross35 Yes, IIRC it is because I also need the |
@tgross35 Sorry, I was a bit pre-occupied the last week and lost track of the status here. Is there anything else I can help you with? |
@tgross35 Is there anything I can help with to get the changes merged into the libc-0.2 branch / release? There is a conference coming soon with some of the RTEMS folk present and I was hoping to give them a demo with the sources of the public repos, so they can start playing around with Rust as well 🙏. |
Oh don't worry about this, I just forgot to close it :) Thanks for the follow up, we'll figure out something better at some point but it isn't pressing. |
@tgross35 ok, thanks. Should I prepare a PR for backporting the things to the libc-0.2 branch? |
Don't worry about it, I plan to do a round of cherry picks this weekend and will include the relevant ones as long as there isn't any major conflict. |
Perfect. Thanks a lot. |
Clean up code added in #3866