Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rtems cfg-ed import with the others #3932

Closed
wants to merge 1 commit into from

Conversation

tgross35
Copy link
Contributor

Clean up code added in #3866

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor Author

@thesummer just noticed this when starting a backport, is there any reason it was in a separate cfg block in #3866?

@thesummer
Copy link
Contributor

thesummer commented Sep 17, 2024

@thesummer just noticed this when starting a backport, is there any reason it was in a separate cfg block in #3866?

@tgross35 Yes, IIRC it is because I also need the arm config block enabled. If it is in the general else-if chain it will be only one of the two.
Atm one could include the arm module also in the rtems branch. However, this might need to be changed if other RTEMS targets are added (but we can also change it when the time comes).

@thesummer
Copy link
Contributor

@tgross35 Sorry, I was a bit pre-occupied the last week and lost track of the status here. Is there anything else I can help you with?

@thesummer thesummer mentioned this pull request Sep 27, 2024
@thesummer
Copy link
Contributor

@tgross35 Is there anything I can help with to get the changes merged into the libc-0.2 branch / release?

There is a conference coming soon with some of the RTEMS folk present and I was hoping to give them a demo with the sources of the public repos, so they can start playing around with Rust as well 🙏.

@tgross35
Copy link
Contributor Author

Oh don't worry about this, I just forgot to close it :) Thanks for the follow up, we'll figure out something better at some point but it isn't pressing.

@tgross35 tgross35 closed this Oct 11, 2024
@tgross35 tgross35 deleted the rtems-cfg-fix branch October 11, 2024 22:04
@thesummer
Copy link
Contributor

@tgross35 ok, thanks. Should I prepare a PR for backporting the things to the libc-0.2 branch?

@tgross35
Copy link
Contributor Author

Don't worry about it, I plan to do a round of cherry picks this weekend and will include the relevant ones as long as there isn't any major conflict.

@thesummer
Copy link
Contributor

Perfect. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants