-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ioctl
flags in linux/if_tun.h
#3960
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Could you please squash the "update codestyle" commits into their previous commits and rebase to get rid of the merge commit? Or just squash into one if that's easier.
@rustbot author Just comment |
@rustbot review |
Needs #4013 for CI to pass again |
fix: values under different architectures style: update code style fix: remove `TUNSETCARRIER` and `TUNGETDEVNETNS` feat: add `TUNSETCARRIER` and `TUNGETDEVNETNS` in `gnu` style: update code style
fix: values under different architectures style: update code style fix: remove `TUNSETCARRIER` and `TUNGETDEVNETNS` feat: add `TUNSETCARRIER` and `TUNGETDEVNETNS` in `gnu` style: update code style (backport <rust-lang#3960>) (cherry picked from commit c24c516)
fix: values under different architectures style: update code style fix: remove `TUNSETCARRIER` and `TUNGETDEVNETNS` feat: add `TUNSETCARRIER` and `TUNGETDEVNETNS` in `gnu` style: update code style (backport <rust-lang#3960>) (cherry picked from commit c24c516)
Description
Add
ioctl
flags fromlinux/if_tun.h
Sources
https://github.com/torvalds/linux/blob/d3d1556696c1a993eec54ac585fe5bf677e07474/include/uapi/linux/if_tun.h#L31
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI