Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getentropy to RTEMS #3973

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

thesummer
Copy link
Contributor

Description

With the newest updates in the compiler the getentropy method is needed and not exposed for RTEMS.
This PR adds the function prototype to the rtems module

Sources

  • Having the getentropy method is mandatory for all RTEMS board support packages according to the RTEMS BSP documentation.
  • The method itself is declared in unistd.h

Checklist

  • [x ] Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@thesummer
Copy link
Contributor Author

r? @tgross35 This is a one-line follow-up. I tried to build the most recent rustc with the current libc-0.2 after your merge and it seems now the getentropy function is also required.

@rustbot rustbot assigned tgross35 and unassigned JohnTitor Oct 15, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 15, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into rust-lang:main with commit e9fd382 Oct 15, 2024
40 of 41 checks passed
@tgross35 tgross35 mentioned this pull request Oct 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 16, 2024
(backport <rust-lang#3973>)
(cherry picked from commit a4ef31b)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants