Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp-idf time flag #3993

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

SergioGasquez
Copy link
Contributor

Description

This PR updates the ESP-IDF time flag, instead of having a espidf_time64, we will have a espidf_time32 flag. espidf_time64 was enabling support for ESP-IDF 5 (latest stable), while espidf_time32 enables support for ESP-IDF 4 (which is now end of life). So making ESP-IDF 4 the opt-in and having ESP-IDF 5 enabled by default makes sense.

See esp-rs/esp-idf-sys#306 (comment) for more information.

cc: @ivmarkov

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense. Do you want this in 0.2 stable, considering it is a breaking change?

@tgross35 tgross35 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into rust-lang:main with commit 6626f72 Oct 24, 2024
41 checks passed
@SergioGasquez
Copy link
Contributor Author

Do you want this in 0.2 stable, considering it is a breaking change?

Yes, our idea is to get it into 0.2 stable.

cc: @ivmarkov

@SergioGasquez SergioGasquez deleted the feat/esp-idf-flags branch October 24, 2024 11:14
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 24, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
(backport <rust-lang#3993>)
(cherry picked from commit 7bd7276)
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants