Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i686-unknown-freebsd to CI #3997

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Oct 25, 2024

Add i686-unknown-freebsd to CI. Run it using 32-bit emulation in a 64-bit environment, with the nightly compiler only.

So as to avoid a repeat of rust-lang/rust#130677

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

It looks like the freebsd CI is failing on all PRs. Any idea why?

I wonder if something broke in a recent nightly.

@asomers
Copy link
Contributor Author

asomers commented Oct 25, 2024

It looks like the freebsd CI is failing on all PRs. Any idea why?

I wonder if something broke in a recent nightly.

I'm investigating that. rust-lang/rust#132185

@bors
Copy link
Contributor

bors commented Nov 4, 2024

☔ The latest upstream changes (presumably #4000) made this pull request unmergeable. Please resolve the merge conflicts.

Add i686-unknown-freebsd to CI.  Run it using 32-bit emulation in a
64-bit environment, with the nightly compiler only.

So as to avoid a repeat of rust-lang/rust#130677
@asomers asomers force-pushed the i686-unknown-freebsd-ci branch 2 times, most recently from 4fe6557 to ce0a306 Compare November 8, 2024 15:16
@asomers asomers marked this pull request as ready for review November 8, 2024 17:00
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 12, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into rust-lang:main with commit d3f2c14 Nov 12, 2024
43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 13, 2024
Add i686-unknown-freebsd to CI.  Run it using 32-bit emulation in a
64-bit environment, with the nightly compiler only.

So as to avoid a repeat of rust-lang/rust#130677

(backport <rust-lang#3997>)
(cherry picked from commit ce0a306)
@tgross35 tgross35 mentioned this pull request Nov 13, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants