Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EAI_SYSTEM getaddrinfo error code. #402

Merged
merged 1 commit into from Sep 26, 2016
Merged

Add EAI_SYSTEM getaddrinfo error code. #402

merged 1 commit into from Sep 26, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2016

This is useful to decide if value returned from getaddrinfo is actual
error or you should look at errno instead.

@bvinc
Copy link

bvinc commented Sep 22, 2016

This is needed for rust-lang/rust#36546. I was looking at this earlier. Looks good to me.

@semarie
Copy link
Contributor

semarie commented Sep 23, 2016

bitrig and openbsd definitions could be factorized in src/unix/bsd/netbsdlike/openbsdlike/mod.rs

@ghost
Copy link
Author

ghost commented Sep 23, 2016

@semarie moved OpenBSD and Bitrig changes into common openbsdlike mod, thanks.

@bvinc indeed, the issue rust-lang/rust#36546 was original motivation for this change.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 25, 2016

📌 Commit cb24847 has been approved by alexcrichton

@alexcrichton
Copy link
Member

Thanks!

@bors
Copy link
Contributor

bors commented Sep 26, 2016

☔ The latest upstream changes (presumably #400) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 26, 2016

🔒 Merge conflict

This is useful to decide if value returned from getaddrinfo is actual
error or you should look at errno instead.
@ghost
Copy link
Author

ghost commented Sep 26, 2016

Rebased.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 26, 2016

📌 Commit f514d46 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 26, 2016

⌛ Testing commit f514d46 with merge eb708c0...

bors added a commit that referenced this pull request Sep 26, 2016
Add EAI_SYSTEM getaddrinfo error code.

This is useful to decide if value returned from getaddrinfo is actual
error or you should look at errno instead.
@bors
Copy link
Contributor

bors commented Sep 26, 2016

☀️ Test successful - status-appveyor, travis
Approved by: alexcrichton
Pushing eb708c0 to master...

@bors bors merged commit f514d46 into rust-lang:master Sep 26, 2016
@ghost ghost deleted the getaddrinfo-error-codes branch September 26, 2016 21:37
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Replace parts of ffi module by libc functions ind sched.rs

Not exporting `CpuMask` anymore, should be the only API change of this PR. Since the type is not used in any other exported signature or type, I think it is fine to no longer export it.

r? @kamalmarhubi @posborne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants