-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2] Remove array size hacks for Rust < 1.47 #4062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Rust >= 1.47 supports traits for arrays of arbitrary size, so remove the various hacks using nested arrays when the native platform definition uses a single array.
tgross35
force-pushed
the
array-size-hacks
branch
from
November 16, 2024 20:18
fd2f724
to
27ee6fe
Compare
Sources: * FreeBSD `__reserve_pad`: [1] * NetBSD `accept_filter_arg`: https://man.netbsd.org/setsockopt.2 [1]: https://github.com/freebsd/freebsd-src/blob/4b4e88d9425b59a377a71ffeb553376b1c60a80e/sys/netinet/sctp_uio.h#L110-L146
tgross35
changed the title
Remove array size hacks for Rust < 1.47
[0.2] Remove array size hacks for Rust < 1.47
Nov 16, 2024
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Rust >= 1.47 supports traits for arrays of arbitrary size, so remove the various hacks using nested arrays when the native platform definition uses a single array. (apply <rust-lang#4062> to `main`) (cherry picked from commit 27ee6fe)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Sources: * FreeBSD `__reserve_pad`: [1] * NetBSD `accept_filter_arg`: https://man.netbsd.org/setsockopt.2 [1]: https://github.com/freebsd/freebsd-src/blob/4b4e88d9425b59a377a71ffeb553376b1c60a80e/sys/netinet/sctp_uio.h#L110-L146 (apply <rust-lang#4062> to `main`) (cherry picked from commit d63be8b)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Rust >= 1.47 supports traits for arrays of arbitrary size, so remove the various hacks using nested arrays when the native platform definition uses a single array. (apply <rust-lang#4062> to `main`) (cherry picked from commit 27ee6fe)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Sources: * FreeBSD `__reserve_pad`: [1] * NetBSD `accept_filter_arg`: https://man.netbsd.org/setsockopt.2 [1]: https://github.com/freebsd/freebsd-src/blob/4b4e88d9425b59a377a71ffeb553376b1c60a80e/sys/netinet/sctp_uio.h#L110-L146 (apply <rust-lang#4062> to `main`) (cherry picked from commit d63be8b)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Rust >= 1.47 supports traits for arrays of arbitrary size, so remove the various hacks using nested arrays when the native platform definition uses a single array. (apply <rust-lang#4062> to `main`) (cherry picked from commit 27ee6fe)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
Sources: * FreeBSD `__reserve_pad`: [1] * NetBSD `accept_filter_arg`: https://man.netbsd.org/setsockopt.2 [1]: https://github.com/freebsd/freebsd-src/blob/4b4e88d9425b59a377a71ffeb553376b1c60a80e/sys/netinet/sctp_uio.h#L110-L146 (apply <rust-lang#4062> to `main`) (cherry picked from commit d63be8b)
tgross35
added
the
main-applied
This PR was merged against libc-0.2 and main has since been updated to include it
label
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
main-applied
This PR was merged against libc-0.2 and main has since been updated to include it
O-android
O-dragonfly
O-gnu
O-linux
O-macos
O-musl
O-unix
S-waiting-on-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust >= 1.47 supports traits for arrays of arbitrary size, so remove the various hacks using nested arrays when the native platform definition uses a single array.
Cherry picked from #2845