Handle remaining leading :: in paths
#4162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Nov 27, 2024
| @@ -26,7 +26,7 @@ s_no_extra_traits! { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) const _ALIGNBYTES: usize = ::mem::size_of::<c_long>() - 1; | |||
| pub(crate) const _ALIGNBYTES: usize = core::mem::size_of::<c_long>() - 1; | |||
There was a problem hiding this comment.
For anything core:: here, could you use crate:: instead? We realized this is a problem with rustc-dep-of-std (I'm working on fixing the rest)
There was a problem hiding this comment.
Actually maybe just hold off until I can merge #4161, that will make this a bit easier since it can just be mem::size_of.
There was a problem hiding this comment.
I stand corrected, this actually shouldn't be a problem. (I think, I'll be adding tests soon). But thanks for changing it anyway.
I looked for `[^\w]::` and fixed them manually.
eduardosm
force-pushed
the
leading-colon-colon
branch
from
4b03c29 to
82d30c6
Compare
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 28, 2024
I looked for `[^\w]::` and fixed them manually. (backport <rust-lang#4162>) (cherry picked from commit 82d30c6)
Merged
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for
[^\w]::and fixed them manually.Description
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI