-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESP-IDF c_char
type
#4195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is marked as a draft?
@ivmarkov wanted to do a small test, that's why I marked it as draft until we confirm that it works, but if you think the change is small enough I can mark it as ready |
Happy to have tests! There probably won't be another release until next week anyway. |
Tests passed successfully. @SergioGasquez if you could "un-draft" the PR? Long explanation:
|
Thanks for confirming! |
@tgross35 somehow this PR did fall out from the merge queue. Is it something we need to address? Weird. |
Thanks for the reminder, I tried adding it back. We just have some tests that are a bit flaky. |
@tgross35 Sorry to bother - but I think we need this in the 0.2 branch as well. |
Indeed, it has the label so it will be in the next release. I was originally planning to do a release next week - but I guess ideally you need it as soon as possible? Assuming so, I'll try to get one out within the next couple days instead. |
Yes, ASAP would be deeply appreciated as we are broken since... some time. :-) Thank you so much! |
(backport <rust-lang#4195>) (cherry picked from commit c66faeb)
Description
Updates the
c_chart
type for ESP-IDF after rust-lang/rust#132975Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI