-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pthread_set_name_np from NuttX #4251
Conversation
LGTM, blocked on #4254 for CI fixes. |
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
I only noticed these two when doing a scan for PRs without a |
Thanks, get it. |
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#4251>) (cherry picked from commit f4ab0b1)
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#4251>) (cherry picked from commit f4ab0b1)
Description
Removed
pthread_set_name_np
function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementationSources
https://github.com/apache/nuttx/blob/8f3a2a6f7645dd95b6a7608b9cde3cb693b118c2/include/pthread.h#L511-L514
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI