Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pthread_set_name_np from NuttX #4251

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 24, 2025

Description

Removed pthread_set_name_np function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation

Sources

https://github.com/apache/nuttx/blob/8f3a2a6f7645dd95b6a7608b9cde3cb693b118c2/include/pthread.h#L511-L514

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

LGTM, blocked on #4254 for CI fixes.

Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API,
this change aligns the code with the actual NuttX implementation

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@tgross35 tgross35 enabled auto-merge February 5, 2025 11:15
@tgross35 tgross35 added this pull request to the merge queue Feb 5, 2025
auto-merge was automatically disabled February 5, 2025 11:44

Pull Request is not mergeable

Merged via the queue into rust-lang:main with commit 478f19d Feb 5, 2025
44 checks passed
@tgross35
Copy link
Contributor

This is a bugfix to a tier3 target so I'll backport it unless you have any objection @no1wudi.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 10, 2025
@no1wudi
Copy link
Contributor Author

no1wudi commented Mar 10, 2025

@tgross35 Thanks!
BTW patches from #4222 is also needed :)

@tgross35
Copy link
Contributor

I only noticed these two when doing a scan for PRs without a stable-* label, but they'll be in this release. Feel free to ping me in the future if something backportable gets missed :) (or add stable-nominated yourself via Rustbot)

@no1wudi
Copy link
Contributor Author

no1wudi commented Mar 10, 2025

I only noticed these two when doing a scan for PRs without a stable-* label, but they'll be in this release. Feel free to ping me in the future if something backportable gets missed :) (or add stable-nominated yourself via Rustbot)

Thanks, get it.

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API,
this change aligns the code with the actual NuttX implementation

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4251>)
(cherry picked from commit f4ab0b1)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API,
this change aligns the code with the actual NuttX implementation

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4251>)
(cherry picked from commit f4ab0b1)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants