Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out the stat struct for gnu/b32/mips #4276

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Split out the stat struct for gnu/b32/mips #4276

merged 2 commits into from
Feb 23, 2025

Conversation

snogge
Copy link
Contributor

@snogge snogge commented Feb 19, 2025

Description

The stat struct is significantly different for GNU 32 bit mips. Split it out to make future work on _FILE_OFFSET_BITS=64 and _TIME_BITS=64 easier.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

There is no way to test mips builds at the moment. This change does not add, change or remove any constants, structs or functions.

@snogge
gnu b32: Copy struct stat to mips and use it
6653298 
Just a simple copy, no cfg conditionals have been removed.  This makes
it easier to review this commit.
@snogge
gnu b32: Remove mips cfg conditionals in struct stat
a092eed 
Now that mips has its own copy of struct stat, remove all the cfg
conditionals used to handle the difference between mips and everything
else.

Future support for _FILE_OFFSET_BITS=64 and _TIME_BITS=64 will be much
easier when the mips differences does not have to be handled in the
same conditionals.
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, uapi defines these separately anyway.

@tgross35 tgross35 added this pull request to the merge queue Feb 23, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Feb 23, 2025
Merged via the queue into rust-lang:main with commit cb4bb18 Feb 23, 2025
44 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Copy struct stat to mips and use it
0786163 
Just a simple copy, no cfg conditionals have been removed.  This makes
it easier to review this commit.

(backport <rust-lang#4276>)
(cherry picked from commit 6653298)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Remove mips cfg conditionals in struct stat
dee6caa 
Now that mips has its own copy of struct stat, remove all the cfg
conditionals used to handle the difference between mips and everything
else.

Future support for _FILE_OFFSET_BITS=64 and _TIME_BITS=64 will be much
easier when the mips differences does not have to be handled in the
same conditionals.

(backport <rust-lang#4276>)
(cherry picked from commit a092eed)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Copy struct stat to mips and use it
2b3d728 
Just a simple copy, no cfg conditionals have been removed.  This makes
it easier to review this commit.

(backport <rust-lang#4276>)
(cherry picked from commit 6653298)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Remove mips cfg conditionals in struct stat
eb32ccd 
Now that mips has its own copy of struct stat, remove all the cfg
conditionals used to handle the difference between mips and everything
else.

Future support for _FILE_OFFSET_BITS=64 and _TIME_BITS=64 will be much
easier when the mips differences does not have to be handled in the
same conditionals.

(backport <rust-lang#4276>)
(cherry picked from commit a092eed)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Copy struct stat to mips and use it
c147b4c 
Just a simple copy, no cfg conditionals have been removed.  This makes
it easier to review this commit.

(backport <rust-lang#4276>)
(cherry picked from commit 6653298)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Remove mips cfg conditionals in struct stat
cacf169 
Now that mips has its own copy of struct stat, remove all the cfg
conditionals used to handle the difference between mips and everything
else.

Future support for _FILE_OFFSET_BITS=64 and _TIME_BITS=64 will be much
easier when the mips differences does not have to be handled in the
same conditionals.

(backport <rust-lang#4276>)
(cherry picked from commit a092eed)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Copy struct stat to mips and use it
5d9a22f 
Just a simple copy, no cfg conditionals have been removed.  This makes
it easier to review this commit.

(backport <rust-lang#4276>)
(cherry picked from commit 6653298)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@snogge @tgross35
gnu b32: Remove mips cfg conditionals in struct stat
d67c994 
Now that mips has its own copy of struct stat, remove all the cfg
conditionals used to handle the difference between mips and everything
else.

Future support for _FILE_OFFSET_BITS=64 and _TIME_BITS=64 will be much
easier when the mips differences does not have to be handled in the
same conditionals.

(backport <rust-lang#4276>)
(cherry picked from commit a092eed)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
O-gnu O-linux O-mips O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snogge @rustbot @tgross35