-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbsd: add devname(3) #4285
openbsd: add devname(3) #4285
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in OpenBSD module cc @semarie |
LGTM. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
(backport <rust-lang#4285>) (cherry picked from commit d27a284)
(backport <rust-lang#4285>) (cherry picked from commit d27a284)
(backport <rust-lang#4285>) (cherry picked from commit d27a284)
(backport <rust-lang#4285>) (cherry picked from commit d27a284)
Description
I'm planning to add OpenBSD support to the drm crate, for that I need devname(3) to replace devname_r which is used on FreeBSD but not available on OpenBSD.
Sources
https://man.openbsd.org/devname.3
https://github.com/openbsd/src/blob/master/include/stdlib.h#L283
https://github.com/openbsd/src/blob/master/lib/libc/gen/devname.c#L73
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI