-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closefrom: add NetBSD, OpenBSD, DragonflyBSD #4290
Conversation
Some changes occurred in OpenBSD module cc @semarie |
the return type of so the tests are failing on OpenBSD :
|
NetBSD, OpenBSD and DragonFly return c_int, FreeBSD returns void, so we can't just add it in freebsdlike. Apple doesn't seem to support closefrom at all at this point.
Absolutely correct @semarie, thanks! No idea how i didn't catch that but it should be fixed now. |
thanks, it passes the test now. the i686-linux-android fails seems unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yeah, android CI is very flaky.
NetBSD, OpenBSD and DragonFly return c_int, FreeBSD returns void, so we can't just add it in freebsdlike. Apple doesn't seem to support closefrom at all at this point. (backport <rust-lang#4290>) (cherry picked from commit 8512ab4)
NetBSD, OpenBSD and DragonFly return c_int, FreeBSD returns void, so we can't just add it in freebsdlike. Apple doesn't seem to support closefrom at all at this point. (backport <rust-lang#4290>) (cherry picked from commit 8512ab4)
NetBSD, OpenBSD and DragonFly return c_int, FreeBSD returns void, so we can't just add it in freebsdlike. Apple doesn't seem to support closefrom at all at this point. (backport <rust-lang#4290>) (cherry picked from commit 8512ab4)
NetBSD, OpenBSD and DragonFly return c_int, FreeBSD returns void, so we can't just add it in freebsdlike. Apple doesn't seem to support closefrom at all at this point. (backport <rust-lang#4290>) (cherry picked from commit 8512ab4)
Description
closefrom is actually widely adopted in *BSD. The only one that seems to not support it at this point is macOS.
This effectively adds closefrom for NetBSD, OpenBSD and DragonFly.
Sources
https://leaf.dragonflybsd.org/cgi/web-man?command=closefrom
https://man.netbsd.org/closefrom.3
https://man.openbsd.org/closefrom.2
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI