-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct values for SI_TIMER, SI_MESGQ, SI_ASYNCIO on Linux MIPS #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See arch/mips/include/uapi/asm/siginfo.h
tgross35
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, permalinks are better for the PR description so we know if things change (I updated this one).
@rustbot label stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h (backport <rust-lang#4292>) (cherry picked from commit 1f8474e)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h (backport <rust-lang#4292>) (cherry picked from commit 1f8474e)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h (backport <rust-lang#4292>) (cherry picked from commit 1f8474e)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h (backport <rust-lang#4292>) (cherry picked from commit 1f8474e)
Merged
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-linux-like
O-unix
S-waiting-on-review
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct values for SI_TIMER, SI_MESGQ, SI_ASYNCIO for Linux MIPS
Sources
https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/arch/mips/include/uapi/asm/siginfo.h#L26-L28
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
It's not possible to test mips at the moment. I found these issues by cross-compiling the tests in yocto with rust 1.82.