Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct values for SI_TIMER, SI_MESGQ, SI_ASYNCIO on Linux MIPS #4292

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

snogge
Copy link
Contributor

@snogge snogge commented Mar 3, 2025

Description

Correct values for SI_TIMER, SI_MESGQ, SI_ASYNCIO for Linux MIPS

Sources

https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/arch/mips/include/uapi/asm/siginfo.h#L26-L28

Checklist

  • [x ] Relevant tests in libc-test/semver have been updated
  • [ x] No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

It's not possible to test mips at the moment. I found these issues by cross-compiling the tests in yocto with rust 1.82.

See arch/mips/include/uapi/asm/siginfo.h
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, permalinks are better for the PR description so we know if things change (I updated this one).

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 3, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 3, 2025
Merged via the queue into rust-lang:main with commit c6976e4 Mar 3, 2025
44 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h

(backport <rust-lang#4292>)
(cherry picked from commit 1f8474e)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h

(backport <rust-lang#4292>)
(cherry picked from commit 1f8474e)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h

(backport <rust-lang#4292>)
(cherry picked from commit 1f8474e)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
See arch/mips/include/uapi/asm/siginfo.h

(backport <rust-lang#4292>)
(cherry picked from commit 1f8474e)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-linux-like O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants