-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: add missing tls bindings #4296
base: main
Are you sure you want to change the base?
Conversation
Permalink to the headers in their current state https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/include/uapi/linux/tls.h (you can get these from the triple dot menu at the top right of the file view). The CI failure just needs you to sort |
The test that failed gives the same errors that I experienced when testing my commit locally. Is it the CI system or something wrong with my implementation? It also cancelled the rest, so I can't check if the problem will occur for them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the CI problem should be fixed with #4311. Could you rebase and squash?
ab54eca
to
fc84ede
Compare
Hm, are these headers just not available on loongarch musl for some reason? Cc @heiher in case you know something. |
fc84ede
to
f7235c3
Compare
f7235c3
to
e8d564e
Compare
This should work now, @mbyx could you squash please? |
30edaf5
to
e0153ff
Compare
Sorry, but this is my first time having to squash, I think I'm not doing it properly, could you please guide me? |
sort semver/linux.txt properly
e0153ff
to
bdcb3eb
Compare
Description
Adds missing TLS bindings for linux as mentioned in #3149. Tests should pass as long as the kernel used for testing implements them.
Sources
Previously only a part of the header had been implemented, now everything has been bound except for placeholder values (__TLS_INFO_MAX, TLS_INFO_MAX).
https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/include/uapi/linux/tls.h
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
I was unable to test locally due to errors similar to Unable to run tests in libc-test using musl (Alpine Linux 3.18.2) #3305.