Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build & link on cygwin #4308

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix build & link on cygwin #4308

merged 2 commits into from
Mar 7, 2025
+8 −7

Conversation

Berrysoft
Copy link
Contributor

It's a fix for #4279 . My fault:(

@Berrysoft
Fix usage of f!
Loading
Loading status checks…
cd4be97
@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Berrysoft Berrysoft mentioned this pull request Mar 7, 2025
Merged
3 tasks
@Berrysoft
Fix strerror_r
Loading
Loading status checks…
e5f9b4e
@Berrysoft Berrysoft changed the title Fix usage of macro f Fix build & link on cygwin Mar 7, 2025
@Berrysoft Berrysoft mentioned this pull request Mar 7, 2025
Merged
1 task
@Berrysoft
Copy link
Contributor Author

Let me explain this PR:

  • It fixes the usage of f!. The signatures of functions should have return types, even they are -> ().
  • It fixes the link of strerror_r.

tgross35
tgross35 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macros are unfriendly :) thanks!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 7, 2025
@tgross35 tgross35 enabled auto-merge March 7, 2025 20:11
@tgross35 tgross35 added this pull request to the merge queue Mar 7, 2025
Merged via the queue into rust-lang:main with commit 3914f82 Mar 7, 2025
44 checks passed
@Berrysoft Berrysoft deleted the fix/cygwin-f-macro branch March 8, 2025 01:04
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@Berrysoft @tgross35
Cygwin: Fix usage of f!
4ae867c 
(backport <rust-lang#4308>)
[ update message to mention Cygwin - Trevor ]
(cherry picked from commit cd4be97)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@Berrysoft @tgross35
Cygwin: Fix strerror_r
cf3720f 
(backport <rust-lang#4308>)
[ update message to mention Cygwin - Trevor ]
(cherry picked from commit e5f9b4e)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@Berrysoft @tgross35
Cygwin: Fix usage of f!
46b1b3d 
(backport <rust-lang#4308>)
[ update message to mention Cygwin - Trevor ]
(cherry picked from commit cd4be97)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@Berrysoft @tgross35
Cygwin: Fix strerror_r
d0cdbb1 
(backport <rust-lang#4308>)
[ update message to mention Cygwin - Trevor ]
(cherry picked from commit e5f9b4e)
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35

Assignees

@tgross35 tgross35

Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Berrysoft @rustbot @tgross35