-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HelenOS support #4355
base: main
Are you sure you want to change the base?
Add HelenOS support #4355
Conversation
Ugh, the only error is missing HelenOS target... I planned to merge the compiler and stdlib support at once. But this makes it seem like I will need to first merge no-std support for HelenOS in compiler, then this libc patch can go through, and only then the stdlib PR makes sense? |
Is there a proposal for adding the target to Rust? The changes look pretty reasonable to me, but getting it at least okayed for rustc is a prerequisite for
It is usually preferable to do this anyway; the compiler changes are usually pretty easy and can get merged as soon as the proposal is accepted. Then library changes can build up from there and things don't get slowed down by having a large diff to review at once. |
Per the above @rustbot blocked |
Description
Add support for HelenOS. I would like to get this backported to 0.2, because I also have a stdlib support ready, which depends on libc 0.2. I'll be sending that patch to rust-lang/rust rather soon (this or next week), I hope.
@rustbot label stable-nominated
Sources
All HelenOS source code is at https://github.com/HelenOS/helenos/. There are comments in this patch attributing each section to a specific header file. Files from
common/
andabi/
get included in HelenOS libc by the build system there, fromuspace/lib
we usec
,inet
andposix
, so that's what we link.libstartfiles
is HelenOS' version ofcrt*
files, because they don't distribute them along with the compiler toolchain, but instead as a library.Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
Tested locally as
cargo test
(without the--target
flag), testing for HelenOS targets will require support here in ctest2, I hope for a tier3 target, it is ok to go without these tests for now?