-
Notifications
You must be signed in to change notification settings - Fork 1.2k
libc-test: Switch Linux to ctest-next #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8811208 to
fe15673
Compare
|
Uh oh, I forgot that the enum problem still existed. The other error seems to be a missing |
4b1f6b9 to
ba39417
Compare
|
So the temporary fix to the enum problem mostly works, but it does still seem like |
|
I tested in a completely new crate with the old ctest cloned beside it, it seems that it can't detect an item wrapped inside of the Then I started doing some print debugging in the old ctest, and from what I can understand, given a crate that only has the let krate = ecx.monotonic_expander().expand_crate(krate);it seems to just leave the macro definition behind, deleting the invocation in its internal representation. Then I switched to a crate with only the At first I thought it was because of a lack of using So I think that all this time ctest has just quietly been ignoring |
|
Assuming that in fact Here however, exactly one enum |
libc-test/build.rs
Outdated
| // deprecated since glibc >= 2.29. This allows Rust binaries to link against | ||
| // glibc versions older than 2.29. | ||
| cfg.define("__GLIBC_USE_DEPRECATED_SCANF", None); | ||
| cfg.skip_private(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in the global config now, right?
3f4b787 to
b05917e
Compare
|
If |
f0758a0 to
ee837ae
Compare
|
Just one error left. It seems to be related to 64 and 32 bit time. The test fails on a 32 bit platform with 64 bit time, so it wants to use EDIT: It was the same issue as everything else has been so far, the target wasn't specified for expansion correctly. |
f513922 to
e73a576
Compare
e73a576 to
8b3dd58
Compare
(backport <rust-lang#4647>) (cherry picked from commit 6f115e5)
(backport <rust-lang#4647>) (cherry picked from commit 6f115e5)
(backport <rust-lang#4647>) (cherry picked from commit 6f115e5)
Description
Ports the linux platform to also be tested using
ctest-next.Blocked on #4674.For now it skips tests for
pid_typeandproc_cm_eventC enums (technically they weren't tested before either) because C seems to hide them in userspace.Sources
Checklist
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI