Skip to content

Conversation

@pusateri
Copy link
Contributor

Description

Add missing interface LINK_STATE_* definitions from sys/net/if.h

Sources

https://github.com/NetBSD/src/blob/54613ac4db31045d0ca58a7e2da7af005c6b5cd2/sys/net/if.h#L207
https://github.com/openbsd/src/blob/bac4ed8757bbe68d4cac117487958588ae27e7c2/sys/net/if.h#L135

Checklist

  • [ x] Relevant tests in libc-test/semver have been updated
  • [x ] No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • [ x] Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2025

Some changes occurred in OpenBSD module

cc @semarie

Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tests are passing on OpenBSD.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor enabled auto-merge October 21, 2025 22:17
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you turn the doc comments into regular comments to match the others? Usually we don't add user-facing docs in this crate, instead preferring if the user refers to the manpages.

Also the comments should be permalinks, otherwise they'll wind up getting out of date. On the GH UI you can do this by clicking the triple dots in the top right then "copy permalink".

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants