Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Neg and Not in no_core mode. #484

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jan 2, 2017

Needed by rust-lang/rust#38776 which requires the traits to be implemented even for integer types.
This is already the case with binary operator traits, which always require the trait and its impls.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 3, 2017

📌 Commit 974f7ba has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 3, 2017

⌛ Testing commit 974f7ba with merge 7d57bdc...

bors added a commit that referenced this pull request Jan 3, 2017
Support Neg and Not in no_core mode.

Needed by rust-lang/rust#38776 which requires the traits to be implemented even for integer types.
This is already the case with binary operator traits, which always require the trait and its impls.
@bors
Copy link
Contributor

bors commented Jan 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 7d57bdc to master...

@bors bors merged commit 974f7ba into rust-lang:master Jan 3, 2017
@eddyb eddyb deleted the dox-unops branch January 3, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants